fix: convert to cstrings in PyString::from_object #5008
Conversation
fixes PyO3#5005 This only fixes the API, and adds a test of the API, it does not deprecate the API or introduce a version which takes `&CStr` directly, this can be done later.
|
@davidhewitt thank you so much for releasing this so timely in a patch release! Do you plan on backporting this to the 0.23.x line as well? I'd like to update to 0.24.x but we also depend on |
I don't see why not, but note that you can safely use this api if you take care to null terminate the string yourself, like |
# Related * RUSTSEC: https://rustsec.org/advisories/RUSTSEC-2025-0020 * We are waiting for apache/arrow-rs#7324 to make it into Rerun * See also PyO3/pyo3#5008 (comment) * See also https://rerunio.slack.com/archives/C05694LC2EQ/p1743501811036759
|
As per #5005 (comment), I was not planning to backport. I suspect that almost nobody was using this API, hence why it was broken for so long, so I think the ecosystem risk is low. |
5 participants
fixes #5005
This only fixes the API, and adds a test of the API, it does not deprecate the API or introduce a version which takes
&CStrdirectly, this can be done later.