Repository navigation
always use a Python iterator for sets and frozensets - #3849
Merged
Merged
Conversation
CodSpeed Performance ReportMerging #3849 will degrade performances by 15.63%Comparing Summary
Benchmarks breakdown
|
davidhewitt
force-pushed
the
set-iteration
branch
from
February 17, 2024 08:06
ee58bb5 to
11bc256
Compare
Member
Author
|
At least on codspeed, ignoring the usual volatile benchmarks we see reported here, the benchmarks basically show no difference for removing the "fast" path, so I think this increases the justification for doing this.
|
LilyFirefly
approved these changes
Feb 17, 2024
LilyFirefly
left a comment
LilyFirefly
left a comment
Contributor
There was a problem hiding this comment.
Seems straightforward to me.
Member
Author
|
Thanks for the review! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3762
This removes the branching of
Py_LIMITED_API/not(Py_LIMITED_API)code for iterators ofsetandfrozenset, opting to just use thePy_LIMITED_APIforms in all cases.This is slightly slower but recommended for stability due to use of private API
_PySet_NextEntrywhich might also not work properly when iterating set subclasses (if they override iteration).At the same time I added
ExactSizeIteratorimplementations to both iterators, as we had that previously just for thenot(Py_LIMITED_API)case.Overall this is a code simplification and consistency improvement.