fix: Improve domain matching in Requester.py#3399
Closed
ViktorWelbers wants to merge 1 commit intoPyGithub:mainfrom
Closed
fix: Improve domain matching in Requester.py#3399ViktorWelbers wants to merge 1 commit intoPyGithub:mainfrom
ViktorWelbers wants to merge 1 commit intoPyGithub:mainfrom
Conversation
Enhance domain matching logic to support reverse checks.
EnricoMi
added a commit
that referenced
this pull request
Nov 20, 2025
Collaborator
|
Superseded by #3419. |
Copilot AI
pushed a commit
that referenced
this pull request
Mar 26, 2026
Supports enterprise base urls like `api.SUBDOMAIN.DOMAIN.TLD` to fetch content from `SUBDOMAIN.DOMAIN.TLD`, while not allowing access to `DOMAIN.TLD`. Fixes #3398. Supersedes #3399. Co-authored-by: EnricoMi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance domain matching logic to support reverse checks.
Related to issues described in here: #3398
This PR enables the use of base_urls like "api.github.ORG.com" which would previously have failed to work.
Look into issue for a more detailed report.