Deprecate Team.add_to_members an Team.remove_from_members

EnricoMi · EnricoMi · commit 245150efd3db · 2025-11-19T15:28:14.000+01:00
diff --git a/github/Team.py b/github/Team.py
@@ -279,6 +279,7 @@ def url(self) -> str:
         self._completeIfNotSet(self._url)
         return self._url.value
 
+    @deprecated("Use add_membership instead")
     def add_to_members(self, member: NamedUser) -> None:
         """
         This API call is deprecated. Use `add_membership` instead.
@@ -504,6 +505,7 @@ def remove_membership(self, member: NamedUser) -> None:
         assert isinstance(member, github.NamedUser.NamedUser), member
         headers, data = self._requester.requestJsonAndCheck("DELETE", f"{self.url}/memberships/{member._identity}")
 
+    @deprecated("Use remove_membership instead")
     def remove_from_members(self, member: NamedUser) -> None:
         """
         This API call is deprecated. Use `remove_membership` instead:
diff --git a/tests/ReplayData/Team.testMembers.txt b/tests/ReplayData/Team.testMembers.txt
@@ -35,9 +35,9 @@ https
 PUT
 api.github.com
 None
-/organizations/1234567/team/12345678/members/jacquev6
-{'Authorization': 'token private_token_removed', 'User-Agent': 'PyGithub/Python'}
-None
+/organizations/1234567/team/12345678/memberships/jacquev6
+{'Content-Type': 'application/json', 'Authorization': 'token private_token_removed', 'User-Agent': 'PyGithub/Python'}
+{"role": "member"}
 204
 [('status', '204 No Content'), ('x-ratelimit-remaining', '4971'), ('server', 'nginx/1.0.13'), ('connection', 'keep-alive'), ('x-ratelimit-limit', '5000'), ('etag', '"d41d8cd98f00b204e9800998ecf8427e"'), ('date', 'Sat, 26 May 2012 21:09:55 GMT')]
 
@@ -68,7 +68,7 @@ https
 DELETE
 api.github.com
 None
-/organizations/1234567/team/12345678/members/jacquev6
+/organizations/1234567/team/12345678/memberships/jacquev6
 {'Authorization': 'token private_token_removed', 'User-Agent': 'PyGithub/Python'}
 None
 204
diff --git a/tests/Team.py b/tests/Team.py
@@ -143,10 +143,10 @@ def testMembers(self):
         user = self.g.get_user("jacquev6")
         self.assertListKeyEqual(self.team.get_members(), None, [])
         self.assertFalse(self.team.has_in_members(user))
-        self.team.add_to_members(user)
+        self.team.add_membership(user)
         self.assertListKeyEqual(self.team.get_members(), lambda u: u.login, ["jacquev6"])
         self.assertTrue(self.team.has_in_members(user))
-        self.team.remove_from_members(user)
+        self.team.remove_membership(user)
         self.assertListKeyEqual(self.team.get_members(), None, [])
         self.assertFalse(self.team.has_in_members(user))
         self.team.add_membership(user, "maintainer")
