Skip to content

Updated pull request #314 to current master.#522

Merged
IanLee1521 merged 3 commits intoPyCQA:masterfrom
arthall:issue-314
Jun 2, 2016
Merged

Updated pull request #314 to current master.#522
IanLee1521 merged 3 commits intoPyCQA:masterfrom
arthall:issue-314

Conversation

@arthall
Copy link
Contributor

@arthall arthall commented Jun 2, 2016

Updated pull request #314 to current master, now passes tests in E73.py.

@IanLee1521 IanLee1521 merged commit b02d768 into PyCQA:master Jun 2, 2016
@IanLee1521
Copy link
Member

IanLee1521 commented Jun 2, 2016

Great, thanks @arthall and @darioush ! These are the timing results for a 10k element dict on my laptop for the record:

In [25]: s = str({str(x):x for x in range(10000)})

In [26]: %timeit list(pycodestyle_before.compound_statements(s))
1 loops, best of 3: 762 ms per loop

In [27]: %timeit list(pycodestyle_after.compound_statements(s))
100 loops, best of 3: 9.81 ms per loop

@IanLee1521 IanLee1521 mentioned this pull request Jun 2, 2016
Closed
@IanLee1521 IanLee1521 added this to the 2.1 milestone Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.1

Development

Successfully merging this pull request may close these issues.

2 participants

@arthall @IanLee1521