Support Python 3.5#420
Conversation
This involves fixing a test and avoiding a function deprecated since Python 3.0. https://docs.python.org/dev/library/inspect.html#inspect.getargspec
|
By the way, I think it would be a good idea to enable Travis on pull requests for this repository. Currently pull requests are not tested for some reason. I think it is a Travis CI setting. |
|
I toggled Travis through its control pane (off then on) to re-enable this. Good catch @myint |
|
Can you also add the |
|
|
pep8.py
Outdated
There was a problem hiding this comment.
if sys.version_info >= (3, 3):That will suffice for what we need. inspect.signature was introduced in 3.3 and not before.
|
Should be fixed now. |
|
This looks good to me. 👍 |
|
Merged! Thanks! |
|
Thanks for fixing this issue! 👍 |
The one on PyPI does not support Python 3.5. The fix was made a month ago, but has not been released yet. PyCQA/pycodestyle#420
|
I would be interested in a PyPI release as well. |
2.2.0 (2016-11-14) ------------------ Bugs: * Fixed E305 regression caused by PyCQA#400; PyCQA#593 2.1.0 (2016-11-04) ------------------ Changes: * Report E302 for blank lines before an "async def"; PyCQA#556 * Update our list of tested and supported Python versions which are 2.6, 2.7, 3.2, 3.3, 3.4 and 3.5 as well as the nightly Python build and PyPy. * Report E742 and E743 for functions and classes badly named 'l', 'O', or 'I'. * Report E741 on 'global' and 'nonlocal' statements, as well as prohibited single-letter variables. * Deprecated use of `[pep8]` section name in favor of `[pycodestyle]`; PyCQA#591 Bugs: * Fix opt_type AssertionError when using Flake8 2.6.2 and pycodestyle; PyCQA#561 * Require two blank lines after toplevel def, class; PyCQA#536 * Remove accidentally quadratic computation based on the number of colons. This will make pycodestyle faster in some cases; PyCQA#314 2.0.0 (2016-05-31) ------------------ Changes: * Added tox test support for Python 3.5 and pypy3 * Added check E275 for whitespace on `from ... import ...` lines; PyCQA#489 / PyCQA#491 * Added W503 to the list of codes ignored by default ignore list; PyCQA#498 * Removed use of project level `.pep8` configuration file; PyCQA#364 Bugs: * Fixed bug with treating `~` operator as binary; PyCQA#383 / PyCQA#384 * Identify binary operators as unary; PyCQA#484 / PyCQA#485 1.7.0 (2016-01-12) ------------------ Changes: * Reverted the fix in PyCQA#368, "options passed on command line are only ones accepted" feature. This has many unintended consequences in pep8 and flake8 and needs to be reworked when I have more time. * Added support for Python 3.5. (Issue PyCQA#420 & PyCQA#459) * Added support for multi-line config_file option parsing. (Issue PyCQA#429) * Improved parameter parsing. (Issues PyCQA#420 & PyCQA#456) Bugs: * Fixed BytesWarning on Python 3. (Issue PyCQA#459)
This involves fixing a test and avoiding a function deprecated since Python 3.0.
https://docs.python.org/dev/library/inspect.html#inspect.getargspec