Repository navigation
Support pyproject.toml for configuration #813
Description
I would love to see support for pyproject.toml for the configuration as, e.g., black does
Reacted by Charles, Slavik Svyrydiuk, Théo Delecour, Tobias Hernstig, Mihai Capotă, pmav99, janw, Michal Mazurek, David Tucker, Jan Freyberg and 76 more
Reacted by anthony sottile and Ian Stapleton Cordasco
Activity
IanLee1521 commentedon Dec 16, 2019
@ZeeD26 - would you be willing to submit a PR?
sigmavirus24 commentedon Dec 16, 2019
@IanLee1521 the configuration management in this project is an abysmal nightmare. Until someone has time to do serious refactoring, I strongly advise against accepting this as a feature.
IanLee1521 commentedon Dec 17, 2019
Good point.
asears commentedon Dec 15, 2020
Is there more traction now for pyproject.toml format? Seems more prevalent on Github. We are looking at Poetry and this would be useful to have central configuration.
sigmavirus24 commentedon Dec 16, 2020
Not really, no
Allow 100 character line length
WiP: Added PEP518 support
carstencodes commentedon Aug 4, 2021
Hi, I must agree to @sigmavirus24, the configuration is really messed up, but I think I found a simple and backward compliant way of adding this feature.
The idea is to read the configuration from the pyproject.toml into a dictionary and add it to the configparser object.
To keep the current behavior, that no dependencies must be used, the feature is added as an extra.
There are still some things to do before #1007 can be merged:
Please tell me, what you think.
pzelnip commentedon Oct 27, 2021
I'm not clear from the discussion: if someone were to implement pyproject.toml support (perhaps via the idea that @carstencodes suggested) would that be welcomed as a contribution? If yes, then it would be appreciated to indicate that clearly so as to encourage a contribution. If not, then I'd suggest this be closed so as to make it clear the format will not be supported (and if that decision is reversed the issue can always be reopened).
carstencodes commentedon Oct 27, 2021
I'll try to add the missing parts on the upcoming weekend. Then it's up to the maintainers to merge or reject this PR.
As we can see in PyCQA/flake8#234, supporting this issue might be hard to accomplish. Since discussion about pyproject.toml support is too heated for some projects (see flake8), it might be a good idea to wait for a toml parser in python (see https://bugs.python.org/issue40059).
Or to use a workaround, like I did with carstencodes/flake518.
sigmavirus24 commentedon Oct 28, 2021
Good idea
holocronweaver commentedon Jun 21, 2022
I see that pydocstyle supports pyproject.toml - could the same approach be taken in pycodestyle?
This seems a fairly popular feature request considering it is both pinned and has received 80+ thumbs up. Maybe a good time to re-open this issue and re-examine, as it is nearing a year since the last update?