Merged
Conversation
This splits the convoluted test files into clearer categories of what is being tested. Previously I had the test file contain semantically correct code, that would also run just fine, except for the errors. I scratched that idea now to aid the readability and understandability of the test file.
mimre25
force-pushed
the
b038-improvements
branch
from
2cd28dd to
7531009
Compare
This commit takes care of detecting mutations stemming from AugAssign and Assign. Also removes incorrect detection of "del foo".
mimre25
force-pushed
the
b038-improvements
branch
from
7531009 to
2cfde40
Compare
cooperlees
approved these changes
Feb 14, 2024
Collaborator
cooperlees
left a comment
cooperlees
left a comment
There was a problem hiding this comment.
Thanks for getting around to it! All looks good to me using tests to see what we flag on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ahh... nothing better than the classic "next week" that turns into a month 😅
This implements all improvements listed in #454.
I've implemented a rather "simple" check for unconditional breaks.
I believe if we want to catch all scenarios, we'll eventually end up with the reachability problem, at least it feels like we're getting close to it.