Repository navigation
Don't panic on unknown AEAD mode in v5/v6 SKESK packets - #322
Merged
Merged
Conversation
Collaborator
|
Could we return an error while decrypting instead of while parsing, for example by modifying |
Contributor
Author
|
done. AEADMode.New, AEADMode.new and getEncryptedKeyAeadInstance now return an error instead of panicking, and the parse-time check is gone, so an unknown mode only fails when decrypting getSymmetricallyEncryptedAeadInstance had to return an error too since it goes through the same path. it also built the nonce slice before constructing the aead, which panicked on an unknown mode before ever reaching mode.new, so that's reordered |
knQzx
force-pushed
the
reject-unknown-aead-skesk
branch
from
August 13, 2026 16:43
850cfd0 to
2ec63f9
Compare
twiss
force-pushed
the
reject-unknown-aead-skesk
branch
from
August 14, 2026 09:36
2ec63f9 to
0daa61e
Compare
twiss
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unknown AEAD mode in a v5/v6 symmetric-key encrypted session key gives a zero tag length, which later divides by the tag length. This rejects unknown modes during parsing.