Skip to content

Scale tip amounts to partial fills when using fulfillOrders (fulfillAvailableAdvancedOrders) #558

@frankisawesome

Description

@frankisawesome

Component

API

Have you ensured that all of these are up to date?

  • seaport-js
  • Node (minimum v16)

What version of seaport-js are you on?

latest

What function is the bug in?

fulfillOrders

Operating System

None

Describe the bug

When calling fulfillOrders with a partial order fulfillment and using a tip, the tip amount is not scaled to the fulfillment proportion. This behaviour was fixed in fulfillOrder.

I intend to have a PR shortly fixing this 👍

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions