Fix incorrect OrderSide in createCollectionOffer price validation#1916
Merged
Fix incorrect OrderSide in createCollectionOffer price validation#1916
Conversation
createCollectionOffer was passing OrderSide.LISTING to getPriceParametersCallback instead of OrderSide.OFFER, bypassing the validation that prevents offers from using native ETH. This aligns it with createOffer and createBulkOffers. Based on #1913 by @Viktohblake. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createCollectionOfferwas passingOrderSide.LISTINGtogetPriceParametersCallbackinstead ofOrderSide.OFFER, bypassing the validation that prevents offers from using native ETHcreateOfferandcreateBulkOfferswhich correctly passOrderSide.OFFERBuilt on top of #1913 by @Viktohblake — same fix without the unrelated
package-lock.jsonchanges.Test plan
OrderSide.OFFERis passed to price parameters callback🤖 Generated with Claude Code