Fix grammar in TransactionConfirmed JSDoc comment#1886
Merged
ryanio merged 1 commit intoProjectOpenSea:mainfrom Feb 11, 2026
Merged
Fix grammar in TransactionConfirmed JSDoc comment#1886ryanio merged 1 commit intoProjectOpenSea:mainfrom
ryanio merged 1 commit intoProjectOpenSea:mainfrom
Conversation
Fixed grammatically incorrect sentence in the TransactionConfirmed event description.
ryanio
approved these changes
Feb 11, 2026
Collaborator
ryanio
left a comment
ryanio
left a comment
There was a problem hiding this comment.
LGTM — fixes the garbled "has succeeded is mined" phrasing. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The JSDoc comment for the TransactionConfirmed event type contained a grammatical error.
Solution
Changed from Emitted when the transaction has succeeded is mined and confirmed to Emitted when the transaction is mined and confirmed.
The original sentence had an awkward phrase has succeeded is mined which was grammatically incorrect.