fix(orders): accept tokenId in eth_price validation#1884
Closed
vikions wants to merge 1 commit intoProjectOpenSea:mainfrom
Closed
fix(orders): accept tokenId in eth_price validation#1884vikions wants to merge 1 commit intoProjectOpenSea:mainfrom
vikions wants to merge 1 commit intoProjectOpenSea:mainfrom
Conversation
3 tasks
Collaborator
|
Thanks for catching this bug! We've incorporated your fix with added unit tests and error message cleanup in #1897. Closing this in favor of that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
eth_priceorderBy validation only checked fortokenIds(plural), butserializeOrdersQueryOptionsalso acceptstokenId(singular). This caused false validation errors when users passed the validtokenIdparameter.Solution
Updated validation in
getOrderandgetOrdersto accept eithertokenIdsortokenId.Changes