fix(api): preserve falsy query params in URL serialization#1875
Merged
Conversation
The objectToSearchParams method was using truthy checks which incorrectly filtered out valid falsy values like 0, false, and empty strings. Changed to explicit null/undefined checks using the idiomatic != null pattern. Also added String() conversion for type safety when appending values to URLSearchParams. Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
objectToSearchParamsto correctly serialize falsy values (0,false, empty strings) that were incorrectly being filtered out by truthy checks!= nullpattern which checks for bothnullandundefinedin one comparisonString()conversion for type safety when appending to URLSearchParamsArray.isArray()first (since arrays are always truthy)This is a cleaner alternative to #1874 which uses the same fix but with more verbose explicit checks.
Changes
Before:
After:
Test plan
0andfalsequery paramsnullandundefinedquery params[0, 1, 2])null/undefinedfrom array params🤖 Generated with Claude Code