fix(api): serialize falsy query params#1874
Closed
kinderjoypresents wants to merge 1 commit intoProjectOpenSea:mainfrom
Closed
fix(api): serialize falsy query params#1874kinderjoypresents wants to merge 1 commit intoProjectOpenSea:mainfrom
kinderjoypresents wants to merge 1 commit intoProjectOpenSea:mainfrom
Conversation
6 tasks
Collaborator
|
Opened a PR for a cleaner approach to this, thanks as always for your contributions! |
Contributor
Author
Ok bro. It was last mine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Query parameter serialization should not drop valid falsy values such as
0orfalse. The previous implementation could omit these values when buildingURLSearchParams, leading to incorrect requests (e.g.limit=0or boolean flags not being sent).Solution
nullandundefined(including0,false, and empty strings).null/undefined.limit=0andinclude=false.