refactor: use Set for shared storefront addresses and checksum remapped address#1864
Merged
refactor: use Set for shared storefront addresses and checksum remapped address#1864
Conversation
…med addresses - Convert SHARED_STOREFRONT_ADDRESSES from array to Set for O(1) lookups - remapSharedStorefrontAddress now returns checksummed addresses via ethers.getAddress() - Gracefully handle invalid addresses by returning them unchanged - Remove uppercase address test since we don't need to handle 0X prefix Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
ryanio
force-pushed
the
refactor/checksum-shared-storefront
branch
from
4d43bdd to
41c1fc1
Compare
Return original tokenAddress unchanged for non-shared storefront addresses. Only return checksummed address when remapping to lazy mint adapter. Co-Authored-By: Claude Opus 4.5 <[email protected]>
ryanio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SHARED_STOREFRONT_ADDRESSESfrom array to Set for O(1) lookups (consistent withVALID_PROTOCOL_ADDRESSESpattern)remapSharedStorefrontAddressreturns checksummed lazy mint adapter address only for shared storefront addressesTest plan
npm test)🤖 Generated with Claude Code