fix(api): Support HTTP-date Retry-After in rate limit handling#1858
Merged
ryanio merged 1 commit intoProjectOpenSea:mainfrom Jan 14, 2026
Merged
Conversation
kinderjoypresents
changed the title
Collaborator
|
thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some APIs return Retry-After as an HTTP-date (RFC 7231) rather than delta-seconds. The current implementation only supports numeric values, which can lead to missing or incorrect retry delays when clients are rate-limited.
Solution
Extend _parseRetryAfter to support both delta-seconds and HTTP-date formats. When an HTTP-date is provided, compute the number of seconds until the retry time. Add unit tests to cover the HTTP-date parsing and past-date behavior.