refactor: cleanup naming conventions and add usesAlternateProtocol helper#1856
Merged
refactor: cleanup naming conventions and add usesAlternateProtocol helper#1856
Conversation
- Rename SIGNED_ZONE to OPENSEA_SIGNED_ZONE_V2 for consistency - Add usesAlternateProtocol() helper to reduce repeated chain checks - Rename getAddressAfterRemappingSharedStorefrontAddressToLazyMintAdapterAddress to remapSharedStorefrontAddress with improved documentation - Keep GUNZILLA_FEE_RECIPIENT as chain-specific (not ALTERNATE_) Co-Authored-By: Claude Opus 4.5 <[email protected]>
ryanio
force-pushed
the
refactor/cleanup-naming
branch
from
5608c14 to
1e7b955
Compare
ryanio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SIGNED_ZONEtoOPENSEA_SIGNED_ZONE_V2for consistency with other OpenSea constantsusesAlternateProtocol()helper to reduce repeatedChain.Gunzilla || Chain.SomniachecksgetAddressAfterRemappingSharedStorefrontAddressToLazyMintAdapterAddresstoremapSharedStorefrontAddresswith improved documentationGUNZILLA_FEE_RECIPIENTas chain-specific (Somnia has its ownSOMNIA_FEE_RECIPIENT)ALTERNATE_*for shared protocol constants (conduit, seaport, signed zone)Test plan
🤖 Generated with Claude Code