refactor: deduplicate checksum logic, rename GUNZILLA→ALTERNATE, update seaport-js#1855
Merged
refactor: deduplicate checksum logic, rename GUNZILLA→ALTERNATE, update seaport-js#1855
Conversation
- Pre-compute checksummed addresses in a Set for O(1) lookups - Reuse requireValidProtocol in getSeaportInstance and getSeaportVersion - Remove ~60 lines of duplicated checksum code Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Co-Authored-By: Claude Opus 4.5 <[email protected]>
ryanio
changed the title
Rename chain-specific protocol constants to be more generic since they're used by multiple chains (Gunzilla, Somnia, etc.): - GUNZILLA_SEAPORT_1_6_ADDRESS → ALTERNATE_SEAPORT_V1_6_ADDRESS - GUNZILLA_CONDUIT_ADDRESS → ALTERNATE_CONDUIT_ADDRESS - GUNZILLA_CONDUIT_KEY → ALTERNATE_CONDUIT_KEY - GUNZILLA_FEE_RECIPIENT → ALTERNATE_FEE_RECIPIENT - GUNZILLA_SIGNED_ZONE_V2_ADDRESS → ALTERNATE_SIGNED_ZONE_V2_ADDRESS Co-Authored-By: Claude Opus 4.5 <[email protected]>
ryanio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Setfor O(1) lookupsrequireValidProtocolingetSeaportInstanceandgetSeaportVersion@opensea/seaport-jsfrom 4.0.5 to 4.0.6GUNZILLA_SEAPORT_1_6_ADDRESS→ALTERNATE_SEAPORT_V1_6_ADDRESSGUNZILLA_CONDUIT_ADDRESS→ALTERNATE_CONDUIT_ADDRESSGUNZILLA_CONDUIT_KEY→ALTERNATE_CONDUIT_KEYGUNZILLA_FEE_RECIPIENT→ALTERNATE_FEE_RECIPIENTGUNZILLA_SIGNED_ZONE_V2_ADDRESS→ALTERNATE_SIGNED_ZONE_V2_ADDRESSTest plan
🤖 Generated with Claude Code