fix: normalize protocol address checksums#1853
Merged
ryanio merged 1 commit intoProjectOpenSea:mainfrom Jan 13, 2026
Merged
Conversation
Normalize protocol constants with ethers.getAddress() before comparing to checksummed inputs to avoid false negatives when constants are not checksummed.
Collaborator
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The SDK compares a checksummed protocolAddress (via ethers.getAddress) against protocol constants that may not be checksummed (e.g. lowercase). Because the comparison was done as a raw string match, valid protocol addresses could be incorrectly treated as unsupported purely due to address formatting/casing differences.
Solution
Normalize the known protocol constants using ethers.getAddress() before performing comparisons in getSeaportInstance and getSeaportVersion. This ensures all comparisons are checksum-consistent and prevents false negatives when resolving supported protocol addresses/versions.