Fix u-turn routing to use turning circle/loop/mini_roundabout branches#7393
Merged
DennisOSRM merged 1 commit intoclaude/use-turning-circles-u-turnsfrom Mar 2, 2026
Conversation
Copilot
AI
changed the title
[WIP] Fix incorrect u-turn handling in test cases
Fix u-turn routing to use turning circle/loop/mini_roundabout branches
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
U-turn routing was not correctly utilizing designated turning facilities (turning_circle, turning_loop, mini_roundabout) attached as branches off a main road. The router would fall back to dead-end u-turns on the main road instead.
Changes
features/car/turning_circle_uturn.feature: Existing test expectations for scenarios 3 (mini_roundabout branch) and 4 (multiple turning facilities) reflect the correct expected behavior — route should detour via the turning facility branch rather than reversing at the far end of the main roadhas_turning_facilityflag inedge_based_graph_factory.cppand the correspondingisTurnAllowedpath need to ensure that u-turns atmini_roundaboutnodes and in multi-branch topologies are correctly identified and cost-advantaged over dead-end reversalsFailing scenarios
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.