Skip to content

Fix incorrect test expectations in turning_circle_uturn feature#7392

Merged
DennisOSRM merged 2 commits intoclaude/use-turning-circles-u-turnsfrom
copilot/fix-build-failure
Mar 2, 2026
Merged

Fix incorrect test expectations in turning_circle_uturn feature#7392
DennisOSRM merged 2 commits intoclaude/use-turning-circles-u-turnsfrom
copilot/fix-build-failure

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 2, 2026

Two scenarios in features/car/turning_circle_uturn.feature had wrong expected values that didn't match OSRM's actual routing output.

Scenario 5: Dead end with turning_circle (a→d, d→a)

Wrong direction: Node c is compressible (degree 2, no obstacles), so there's no real graph intersection there. OSRM emits a new name instruction (not turn) when a road name changes within a compressed edge. The geometry is east→south = right, not left.

Wrong route count: The arrive step always contributes its road name to the route list — standard OSRM behavior, consistent with restrictions.feature and similar tests.

# Before
| a,d | abc,cd   | depart,turn left,arrive  |
| d,a | cd,abc   | depart,turn right,arrive |

# After
| a,d | abc,cd,cd  | depart,new name right,arrive |
| d,a | cd,abc,abc | depart,new name left,arrive  |

Scenario 6: Regular U-turn without turning facility

Expected 2 route name entries but OSRM produces 3 — one per step (depart, continue uturn, arrive). Matches the established pattern in turning_loop.feature where a,a routes yield three route segments.

# Before
| a,a | 90,10 270,10 | abcd,abcd      | depart,continue uturn,arrive |

# After
| a,a | 90,10 270,10 | abcd,abcd,abcd | depart,continue uturn,arrive |
Original prompt

Reference: https://github.com/Project-OSRM/osrm-backend/actions/runs/22563066792/job/65353576390#step:15:1


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI changed the title [WIP] Fix build failure in continuous integration Fix incorrect test expectations in turning_circle_uturn feature Mar 2, 2026
@DennisOSRM DennisOSRM marked this pull request as ready for review March 2, 2026 14:56
@DennisOSRM DennisOSRM merged commit 7e29f37 into claude/use-turning-circles-u-turns Mar 2, 2026
@DennisOSRM DennisOSRM deleted the copilot/fix-build-failure branch March 2, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants