Fix incorrect test expectations in turning_circle_uturn feature#7392
Merged
DennisOSRM merged 2 commits intoclaude/use-turning-circles-u-turnsfrom Mar 2, 2026
Merged
Conversation
…rios 5 and 6 Co-authored-by: DennisOSRM <[email protected]>
Copilot
AI
changed the title
[WIP] Fix build failure in continuous integration
Fix incorrect test expectations in turning_circle_uturn feature
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two scenarios in
features/car/turning_circle_uturn.featurehad wrong expected values that didn't match OSRM's actual routing output.Scenario 5: Dead end with turning_circle (
a→d,d→a)Wrong direction: Node
cis compressible (degree 2, no obstacles), so there's no real graph intersection there. OSRM emits anew nameinstruction (notturn) when a road name changes within a compressed edge. The geometry is east→south = right, not left.Wrong route count: The
arrivestep always contributes its road name to the route list — standard OSRM behavior, consistent withrestrictions.featureand similar tests.Scenario 6: Regular U-turn without turning facility
Expected 2 route name entries but OSRM produces 3 — one per step (
depart,continue uturn,arrive). Matches the established pattern inturning_loop.featurewherea,aroutes yield three route segments.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.