Fix missing ObstacleMap::any(NodeID, Obstacle::Type) overload#7391
Merged
DennisOSRM merged 2 commits intoclaude/use-turning-circles-u-turnsfrom Mar 2, 2026
Merged
Conversation
Co-authored-by: DennisOSRM <[email protected]>
Copilot
AI
changed the title
[WIP] Update documentation for OSRM backend
Fix missing Mar 1, 2026
ObstacleMap::any(NodeID, Obstacle::Type) overload
Collaborator
|
@copilot verify the formatting |
Contributor
Author
Formatting verified with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build was failing because two call sites in
graph_compressor.cppandedge_based_graph_factory.cppinvokedobstacle_map.any(node, Obstacle::Type::Turning)— a 2-argument(to, type)form that didn't exist onObstacleMap.Changes
include/extractor/obstacles.hpp: Add the missing overload:tofrom any direction filtered bytype, consistent with how the existingany(NodeID from, NodeID to, Obstacle::Type)andget(SPECIAL_NODEID, to, type)semantics work.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.