Skip to content

Fix missing ObstacleMap::any(NodeID, Obstacle::Type) overload#7391

Merged
DennisOSRM merged 2 commits intoclaude/use-turning-circles-u-turnsfrom
copilot/update-documentation-for-osrm
Mar 2, 2026
Merged

Fix missing ObstacleMap::any(NodeID, Obstacle::Type) overload#7391
DennisOSRM merged 2 commits intoclaude/use-turning-circles-u-turnsfrom
copilot/update-documentation-for-osrm

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 1, 2026

Build was failing because two call sites in graph_compressor.cpp and edge_based_graph_factory.cpp invoked obstacle_map.any(node, Obstacle::Type::Turning) — a 2-argument (to, type) form that didn't exist on ObstacleMap.

Changes

  • include/extractor/obstacles.hpp: Add the missing overload:
    bool any(NodeID to, Obstacle::Type type) const
    {
        return any(to) && !get(SPECIAL_NODEID, to, type).empty();
    }
    Queries obstacles at to from any direction filtered by type, consistent with how the existing any(NodeID from, NodeID to, Obstacle::Type) and get(SPECIAL_NODEID, to, type) semantics work.
Original prompt

Reference: https://github.com/Project-OSRM/osrm-backend/actions/runs/22553390410/job/65327010999#step:14:1


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@DennisOSRM DennisOSRM marked this pull request as ready for review March 1, 2026 21:56
Copilot AI changed the title [WIP] Update documentation for OSRM backend Fix missing ObstacleMap::any(NodeID, Obstacle::Type) overload Mar 1, 2026
@DennisOSRM
Copy link
Copy Markdown
Collaborator

@copilot verify the formatting

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 1, 2026

@copilot verify the formatting

Formatting verified with clang-format — the file matches the project's format style exactly (no diff).

@DennisOSRM DennisOSRM merged commit 8cdded5 into claude/use-turning-circles-u-turns Mar 2, 2026
1 check passed
@DennisOSRM DennisOSRM deleted the copilot/update-documentation-for-osrm branch March 2, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants