Skip to content

Upgrade clang-format to version 15#6859

Merged
DennisOSRM merged 8 commits intomasterfrom
upgrade_clang_format
May 6, 2024
Merged

Upgrade clang-format to version 15#6859
DennisOSRM merged 8 commits intomasterfrom
upgrade_clang_format

Conversation

@DennisOSRM
Copy link
Copy Markdown
Collaborator

Version 14 is the version available on ubuntu-latest in Github actions

DennisOSRM added 3 commits May 5, 2024 21:10
Version 14 is the version available on ubuntu-latest in Github actions
- name: Prepare environment
run: |
npm ci --ignore-scripts
clang-format-10 --version
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems ubuntu-22.04 has clang-format-15. May be worth updating to it as we have to reformat a lot of files anyway? https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md

Btw 24.04 seems to be already available as well…

Copy link
Copy Markdown
Collaborator Author

@DennisOSRM DennisOSRM May 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh great, then I'll amend this PR to go straight to 24.04.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that 24.04 based runners are not available yet. Sticking to 22.04 for now.

@SiarheiFedartsou SiarheiFedartsou self-requested a review May 6, 2024 05:56
@DennisOSRM DennisOSRM changed the title Upgrade clang-format to version 14 Upgrade clang-format to version 15 May 6, 2024
@DennisOSRM DennisOSRM merged commit 7f9d591 into master May 6, 2024
@DennisOSRM DennisOSRM deleted the upgrade_clang_format branch May 6, 2024 07:14
eliseier pushed a commit to wanderlog/osrm-backend that referenced this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants