Remove unused AWS SDK for JavaScript v2#6730
Merged
mjjbell merged 1 commit intoProject-OSRM:masterfrom Mar 17, 2024
trivikr:remove-aws-sdk
Merged
Remove unused AWS SDK for JavaScript v2#6730mjjbell merged 1 commit intoProject-OSRM:masterfrom trivikr:remove-aws-sdk
mjjbell merged 1 commit intoProject-OSRM:masterfrom
trivikr:remove-aws-sdk
Conversation
Contributor
Author
Member
|
Yes I believe the AWS SDK is no longer needed after #6030 |
mjjbell
approved these changes
Mar 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
From AWS SDK for JavaScript v2 README:
I discovered osrm-backend while searching for popular projects on GitHub which use AWS SDK for JavaScript v2.
On quick look, it appears like the aws-sdk dependency is not needed. It was added in commit 2351b5a
Tasklist
Requirements / Relations
N/A