Increment feature id in tile speed layer#6726
Merged
mjjbell merged 3 commits intoProject-OSRM:masterfrom Mar 24, 2024
Merged
Conversation
mjjbell
approved these changes
Mar 17, 2024
Member
|
LGTM. Can you add a changelog entry? |
datwelk
force-pushed
the
hotfix/tile-id-increment
branch
from
49f8f0d to
d91af12
Compare
Contributor
Author
|
@mjjbell Added changelog entry and rebased on master. Do I need to squash both commits into one or is it fine like this? |
Member
Thanks, it's fine, they will be squashed on merge. |
Member
|
Looks like some node tests are failing, because the underlying PBF varints for the IDs now make it bigger than previously expected. Can you update? osrm-backend/test/nodejs/constants.js Line 13 in 8526cc7 |
eliseier
pushed a commit
to wanderlog/osrm-backend
that referenced
this pull request
Mar 25, 2025
* actually increment feature id in tile speed layer --------- Co-authored-by: Michael Bell <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tile layer currently contains the same id value of "1" for all linestring features in the speeds layer. There's a comment in the codebase that says the id should be incremented for each feature, but this does not happen for the linestring features. It does happen for the turn restriction features a few lines down.
This PR addresses the issue where linestring feature ids are not incremented.