Added block_counter variable to a preprocessor check, minor bug.#6596
Merged
SiarheiFedartsou merged 3 commits intoProject-OSRM:masterfrom Apr 16, 2023
Merged
Added block_counter variable to a preprocessor check, minor bug.#6596SiarheiFedartsou merged 3 commits intoProject-OSRM:masterfrom
SiarheiFedartsou merged 3 commits intoProject-OSRM:masterfrom
Conversation
Contributor
Author
|
One of the workflow runs failed when checking the CHANGELOG.md file with error: Run ./scripts/check_taginfo.py taginfo.json profiles/car.lua
clang-format-10 is /usr/bin/clang-format-10
ERROR ON LINE 13: - ADDED: Print tracebacks for Lua runtime errors [#6564](https://github.com/Project-OSRM/osrm-backend/pull/6564)
ERROR: changelog entries must end with an issue or PR link in Markdown format
Error: Process completed with exit code 1.I'm guessing it could have been because I messed with the order of the Misc items in the changelog a little, so I just put it back the way it was in the master branch. |
SiarheiFedartsou
approved these changes
Apr 16, 2023
Member
|
Thanks! |
Contributor
Author
|
Of course! Glad I could help! |
mugr1x
pushed a commit
to mugr1x/osrm
that referenced
this pull request
Apr 17, 2023
6 tasks
mugr1x
pushed a commit
to mugr1x/osrm
that referenced
this pull request
Apr 19, 2023
mattwigway
pushed a commit
to mattwigway/osrm-backend
that referenced
this pull request
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
This PR closes issue #6589. There was a minor bug where the variable
block_counterin fileosrm-backend/include/util/range_table.hppwas considered as "set but not used" during the build phase, causing an error. That variable was added to a preprocessor guard to solve this issue.Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?