Skip to content

Always install the latest Conan 1.x on CI#6559

Closed
SiarheiFedartsou wants to merge 4 commits intomasterfrom
sf-bump-conan-1.53.0
Closed

Always install the latest Conan 1.x on CI#6559
SiarheiFedartsou wants to merge 4 commits intomasterfrom
sf-bump-conan-1.53.0

Conversation

@SiarheiFedartsou
Copy link
Copy Markdown
Member

@SiarheiFedartsou SiarheiFedartsou commented Feb 28, 2023

Issue

closes #6557

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

- name: Install dev dependencies
run: |
python3 -m pip install conan==1.53.0
python3 -m pip install conan==1.59.0
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, may be it is better to just always install the latest 1.x

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO <2.0.0 is best. It's how I do it on Valhalla, never had problems. In fact we were always installing the latest, which bit us a few days ago when 2.x was released

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree 👍

@SiarheiFedartsou SiarheiFedartsou changed the title Bump Conan to version 1.59.0 Always install the latest Conan 1.x on CI Feb 28, 2023
@SiarheiFedartsou SiarheiFedartsou marked this pull request as ready for review February 28, 2023 18:43
@DennisOSRM DennisOSRM deleted the sf-bump-conan-1.53.0 branch May 3, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mac CI requires higher Conan version

2 participants