Update Docker commands in README to also output error in case of failure#6529
Merged
SiarheiFedartsou merged 1 commit intomasterfrom Jan 29, 2023
Merged
Update Docker commands in README to also output error in case of failure#6529SiarheiFedartsou merged 1 commit intomasterfrom
SiarheiFedartsou merged 1 commit intomasterfrom
Conversation
Member
|
@SiarheiFedartsou thanks, I should've done this years ago, it's such a common problem.... |
danpat
approved these changes
Jan 29, 2023
mattwigway
pushed a commit
to mattwigway/osrm-backend
that referenced
this pull request
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
People often get confused due to the fact that
osrm-extractcan just crash(e.g. due to OOM) and we output nothing in this case - they can have wrong impression that every step finished successfully, but it didn't in fact(example #6528). So I propose to just include this|| echo "... failed"to make it more obvious. It is almost the same as we have in https://github.com/Project-OSRM/osrm-backend/wiki/Docker-Recipes, but a bit less verbose.Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?