Merged
Conversation
It's a mechanical change to modernize the code base
| edge_container.MakeEdgeFilters()}; | ||
| } | ||
| } // namespace contractor | ||
| } // namespace osrm |
Member
There was a problem hiding this comment.
nit. would be great to reflect this in such comments too(if possible to do in automated fashion ofc)
Collaborator
Author
There was a problem hiding this comment.
fair point. I am afraid those are hard to do in an automated way, tho.
Member
There was a problem hiding this comment.
Then I think it is not big problem if we keep it like this
Collaborator
Author
There was a problem hiding this comment.
I spoke too early. The latest push to this PR should fix the closing namespace annotation.
SiarheiFedartsou
approved these changes
Dec 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a mechanical change to modernize the code base