Move vector in CSVFilesParser instead copying it#6470
Merged
SiarheiFedartsou merged 2 commits intomasterfrom Dec 3, 2022
Merged
Move vector in CSVFilesParser instead copying it#6470SiarheiFedartsou merged 2 commits intomasterfrom
SiarheiFedartsou merged 2 commits intomasterfrom
Conversation
DennisOSRM
approved these changes
Dec 3, 2022
Collaborator
DennisOSRM
left a comment
DennisOSRM
left a comment
There was a problem hiding this comment.
Any measurable impact on performance?
Member
Author
Tbh I didn’t make any measurements, but I think it shouldn’t be significant. |
mattwigway
pushed a commit
to mattwigway/osrm-backend
that referenced
this pull request
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Accidentally noticed it, should make things slightly faster.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?