Conversation
| CXXCOMPILER: g++-8 | ||
| CXXFLAGS: -Wno-cast-function-type | ||
|
|
||
| - name: gcc-7-release |
There was a problem hiding this comment.
We probably can add gcc-12 instead in separate PR
There was a problem hiding this comment.
yes, good call with the separate PR. It seems the code doesn't compile cleanly with GCC12, yet. Limited testing started to throw a fair amount of compile errors.
Btw as I understand GCC 8 is minimum compiler version, but not required, i.e. nothing prevents us from using the very latest version of GCC to build bindings when we do it on our own(we actually use clang to do it btw), i.e. the only value of old compilers support is the fact that we enable other people to build OSRM(and probably Node bindings) with these compilers. |
2 participants
Mininum compiler version required to compile Node 16+ is GCC 8.3 according to the NodeJS release announcement.