Skip to content

Apply workaround for Conan installation issue on CI#6442

Merged
SiarheiFedartsou merged 4 commits intomasterfrom
sf-conan-workaround
Nov 5, 2022
Merged

Apply workaround for Conan installation issue on CI#6442
SiarheiFedartsou merged 4 commits intomasterfrom
sf-conan-workaround

Conversation

@SiarheiFedartsou
Copy link
Copy Markdown
Member

Issue

Seems to be related not to Conan itself, but this update of macOS image we are using https://github.com/actions/runner-images/pull/6499/files
Screenshot 2022-11-04 at 11 57 54

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

python3 -m pip install conan==1.53.0
# workaround for issue that GitHub Actions seems to not adding it to PATH after https://github.com/actions/runner-images/pull/6499
# and that's CI cannot find conan executable installed above
if [[ "${RUNNER_OS}" == "macOS" ]]; then
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have created an issue in https://github.com/actions/runner-images repo and I bet there is better fix in general(at least we could detect /Library/Frameworks/Python.framework/Versions/3.11 string automatically), but just want to unblock @DennisOSRM with his PRs

@SiarheiFedartsou SiarheiFedartsou marked this pull request as ready for review November 4, 2022 11:10
@SiarheiFedartsou SiarheiFedartsou changed the title Apply workaround for Conan installation on CI Apply workaround for Conan installation issue on CI Nov 4, 2022
Copy link
Copy Markdown
Collaborator

@DennisOSRM DennisOSRM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@SiarheiFedartsou
Copy link
Copy Markdown
Member Author

I bet it should be fixed by https://github.com/actions/runner-images/pull/6518/files

@SiarheiFedartsou SiarheiFedartsou merged commit 6ab8728 into master Nov 5, 2022
mattwigway pushed a commit to mattwigway/osrm-backend that referenced this pull request Jul 20, 2023
@DennisOSRM DennisOSRM deleted the sf-conan-workaround branch May 3, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants