Remove C++14 references from README and package.json#6438
Merged
SiarheiFedartsou merged 1 commit intomasterfrom Nov 6, 2022
Merged
Remove C++14 references from README and package.json#6438SiarheiFedartsou merged 1 commit intomasterfrom
SiarheiFedartsou merged 1 commit intomasterfrom
Conversation
SiarheiFedartsou
commented
Nov 1, 2022
|
|
||
| [](https://github.com/Project-OSRM/osrm-backend/actions/workflows/osrm-backend.yml) [](https://codecov.io/gh/Project-OSRM/osrm-backend) [](https://discord.gg/es9CdcCXcb) | ||
|
|
||
| High performance routing engine written in C++14 designed to run on OpenStreetMap data. |
Member
Author
There was a problem hiding this comment.
Wanted to make it modern C++, but then realised that C++17 is probably not very modern taking into account that C++23 is going to be released next year :)
Member
Author
There was a problem hiding this comment.
Btw if we are going to bump compiler versions probably nothing prevents from using C++20(not sure what can be really useful there though, but newer C++ standard is always better than older)
DennisOSRM
approved these changes
Nov 4, 2022
mattwigway
pushed a commit
to mattwigway/osrm-backend
that referenced
this pull request
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
We are using C++17 now.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?