Replace boost::string_ref with std::string_view#6433
Merged
DennisOSRM merged 17 commits intomasterfrom Nov 6, 2022
Merged
Conversation
SiarheiFedartsou
approved these changes
Nov 1, 2022
Member
|
Nice to see that you are actively contributing again 🚀 |
Member
|
JFYI there is some annoying issue with Conan installation on macOS executors on CI - I am trying to fix it now. Workaround is to use |
Collaborator
Author
Thanks for letting me know. I'll rebase the PR once the bug is fixed, then. |
| std::string str; | ||
| str.reserve(view.size()); | ||
| std::transform( | ||
| str.begin(), str.end(), str.begin(), [](unsigned char c) { return std::tolower(c); }); |
Member
There was a problem hiding this comment.
I think you have to use std::back_inserter here…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
What issue is this PR targeting? If there is no issue that addresses the problem, please open a corresponding issue and link it here.
Please read our documentation on release and version management.
If your PR is still work in progress please attach the relevant label.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?