Revert back to using custom HTTP parser instead of Boost.Beast#6407
Merged
SiarheiFedartsou merged 5 commits intomasterfrom Oct 14, 2022
Merged
Revert back to using custom HTTP parser instead of Boost.Beast#6407SiarheiFedartsou merged 5 commits intomasterfrom
SiarheiFedartsou merged 5 commits intomasterfrom
Conversation
SiarheiFedartsou
changed the title
| - CHANGED: Add `data_version` field to responses of all services. [#5387](https://github.com/Project-OSRM/osrm-backend/pull/5387) | ||
| - FIXED: Use Boost.Beast to parse HTTP request. [#6294](https://github.com/Project-OSRM/osrm-backend/pull/6294) | ||
| - FIXED: Fix inefficient osrm-routed connection handling [#6113](https://github.com/Project-OSRM/osrm-backend/pull/6113) | ||
| - FIXED: Fix HTTP compression precedence [#6113](https://github.com/Project-OSRM/osrm-backend/pull/6113) |
Member
Author
| @@ -55,4 +55,4 @@ module.exports = function () { | |||
| assert.equal(this.processError.process, binary); | |||
Member
Author
There was a problem hiding this comment.
I didn't remove "large request" test which I added recently - it will be useful to avoid regression as was introduced by Boost.Beast migration.
| } | ||
| } | ||
| else | ||
| RequestParser::RequestStatus result; |
Member
Author
There was a problem hiding this comment.
All changes are made reverting git commits related to Boost.Beast and subsequent fixes.
mjjbell
approved these changes
Oct 14, 2022
SiarheiFedartsou
force-pushed
the
sf-revert-http-parser
branch
from
9244a97 to
5f150a0
Compare
Tested it and works as expected |
Member
Author
|
Thanks @lamaux |
datendelphin
added a commit
to fossgis-routing-server/osrm-backend
that referenced
this pull request
Dec 23, 2022
v5.27.1
- Changes from 5.27.0
- Misc:
- FIXED: Revert back to using custom HTTP parser instead of Boost.Beast. [Project-OSRM#6407](Project-OSRM#6407)
- FIXED: Fix bug with large HTTP requests leading to Bad Request in osrm-routed. [Project-OSRM#6403](Project-OSRM#6403)
- Routing:
- CHANGED: Add support for surface=metal,grass_paver,woodchips in bicyle profile. [Project-OSRM#6395](Project-OSRM#6395)
mattwigway
pushed a commit
to mattwigway/osrm-backend
that referenced
this pull request
Jul 20, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Context: #6400 (comment)
closes #6400
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?