Improvements to maneuver override processing#6215
Merged
mjjbell merged 1 commit intoProject-OSRM:masterfrom Aug 24, 2022
Merged
Improvements to maneuver override processing#6215mjjbell merged 1 commit intoProject-OSRM:masterfrom
mjjbell merged 1 commit intoProject-OSRM:masterfrom
Conversation
mjjbell
force-pushed
the
mbell/maneouvre_assert
branch
2 times, most recently
from
e226cb9 to
05bc3f3
Compare
mjjbell
force-pushed
the
mbell/maneouvre_assert
branch
3 times, most recently
from
061d59b to
a71b651
Compare
SiarheiFedartsou
approved these changes
Aug 23, 2022
Member
SiarheiFedartsou
left a comment
SiarheiFedartsou
left a comment
There was a problem hiding this comment.
LGTM, it is quite hard to review such PRs though - have no deep experience with OSRM codebase yet
mjjbell
force-pushed
the
mbell/maneouvre_assert
branch
from
a71b651 to
74ba0d0
Compare
This change unblocks the osrm-extract debug build, which is currently failing on a maneuver override assertion. The processing of maneuver overrides currently has three issues - It assumes the via node(s) can't be compressed (the failing assertion) - It can't handle via-paths containing incompressible nodes - It doesn't interop with turn restriction on the same path Turn restrictions and maneuver overrides both use the same from-via-to path representation. Therefore, we can fix these issues by consolidating their structures and reusing the path representation for turn restrictions, which already is robust to the above issues. This also simplifies some of the codebase by removing maneuver override specific path processing. There are ~100 maneuver overrides in the OSM database, so the impact on processing and routing will be minimal.
mjjbell
force-pushed
the
mbell/maneouvre_assert
branch
from
74ba0d0 to
6847e49
Compare
mattwigway
pushed a commit
to mattwigway/osrm-backend
that referenced
this pull request
Jul 20, 2023
This change unblocks the osrm-extract debug build, which is currently failing on a maneuver override assertion. The processing of maneuver overrides currently has three issues - It assumes the via node(s) can't be compressed (the failing assertion) - It can't handle via-paths containing incompressible nodes - It doesn't interop with turn restriction on the same path Turn restrictions and maneuver overrides both use the same from-via-to path representation. Therefore, we can fix these issues by consolidating their structures and reusing the path representation for turn restrictions, which already is robust to the above issues. This also simplifies some of the codebase by removing maneuver override specific path processing. There are ~100 maneuver overrides in the OSM database, so the impact on processing and routing will be minimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
This change unblocks the
osrm-extractdebug build, which is currently failing on a maneuver override assertion.The processing of maneuver overrides currently has three issues:
Turn restrictions and maneuver overrides both use the same
from-via-topath representation.Therefore, we can fix these issues by consolidating their structures and reusing the path representation for turn restrictions, which already is robust to the above issues.
This also simplifies some of the codebase by removing maneuver override specific path processing.
There are ~100 maneuver overrides in the OSM database, so the impact on processing and routing will be minimal.
But who knows, with improved support, it might encourage further adoption.
Tasklist
Requirements / Relations
Fixes #6126