Fix for_each_indexed util function#6151
Merged
mjjbell merged 1 commit intoProject-OSRM:masterfrom Dec 22, 2021
Merged
Conversation
- Fix typo in util function name for_each_indexed. - Use the overloaded functions for_each_indexed and for_each_pair with a container argument where possible to improve readability.
mjjbell
commented
Oct 22, 2021
|
|
||
| template <class ContainerT, typename Function> | ||
| void for_each_pair(ContainerT &container, Function function) | ||
| void for_each_indexed(ContainerT &container, Function function) |
Member
Author
There was a problem hiding this comment.
This overload was not being used in the codebase, so the typo went unnoticed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
for_each_indexed.for_each_indexedandfor_each_pairwith a container argument where possible to improve readability.