Merged
Conversation
Fix the typos and some basic grammar mistakes
mjjbell
requested changes
Oct 18, 2021
Member
mjjbell
left a comment
mjjbell
left a comment
There was a problem hiding this comment.
A surprising number of typos when you go through it all 🙂
Only one suggested change.
docs/http.md
Outdated
| ### Table service | ||
|
|
||
| Computes the duration of the fastest route between all pairs of supplied coordinates. Returns the durations or distances or both between the coordinate pairs. Note that the distances are not the shortest distance between two coordinates, but rather the distances of the fastest routes. Duration is in seconds and distances is in meters. | ||
| Computes the duration of the fastest route between all pairs of supplied coordinates. Returns the duration or distances or both between the coordinate pairs. Note that the distances are not the shortest distance between two coordinates, but rather the distances of the fastest routes. Duration is in seconds and distances are in meters. |
Member
There was a problem hiding this comment.
I'd suggest keeping both plural (durations and distances) or both singular (duration and distance) for consistency.
SiarheiFedartsou
approved these changes
Aug 27, 2022
mjjbell
approved these changes
Aug 27, 2022
mattwigway
pushed a commit
to mattwigway/osrm-backend
that referenced
this pull request
Jul 20, 2023
Fix the typos and some basic grammar mistakes Co-authored-by: Siarhei Fedartsou <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the typos and some basic grammar mistakes