Fix the URL parser for special chars in profile#6090
Merged
Conversation
TheMarex
commented
Jul 27, 2021
mjjbell
requested changes
Jul 28, 2021
Member
Author
|
Updated the grammar. Thanks for the review @mjjbell I learned something about boost spirit again (and why I don't like it) 😆 |
Member
mjjbell
requested changes
Aug 28, 2021
Member
mjjbell
left a comment
mjjbell
left a comment
There was a problem hiding this comment.
One minor change to prevent regression.
Co-authored-by: Michael Bell <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The URLs used for
osrm-routedhave the form{service}/{version}/{profile}/{params}?{options...}. The boost spirit grammar for parsing theprofileandserviceidentifiers was artificially limited to only allow alpha-numerical characters, but any URL-safe character would be fine.This PR additionally allows for
._-~.Tasklist