Update node-pre-gyp to fix Node 12/14 installation problems in some environments#5991
Merged
Update node-pre-gyp to fix Node 12/14 installation problems in some environments#5991
Conversation
akashihi
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
needleis a HTTP client library thatnode-pre-gypuses to download binaries. The version ofnode-pre-gypwe depended on (0.12.0) depended on an old version ofneedlethat has this bug: tomas/needle#312 - it broke with Node 12.For users with the
requestmodule available, this problem wasn't noticed. But in greenfield installations ofnpm install osrm, the following error was being encountered:Updating
node-pre-gypupgrades theneedledependency, and fixes the above problem.Tasklist
update relevant Wiki pagesadd tests (see testing documentation