Undo libosrm API break by overloading method response types#5860
Closed
mjjbell wants to merge 1 commit intoProject-OSRM:masterfrom
Closed
Undo libosrm API break by overloading method response types#5860mjjbell wants to merge 1 commit intoProject-OSRM:masterfrom
mjjbell wants to merge 1 commit intoProject-OSRM:masterfrom
Conversation
mjjbell
force-pushed
the
mbell/libosrm_api
branch
5 times, most recently
from
9094379 to
06da13d
Compare
Removes the breaking libosrm API change by replacing the use of variant response type with method overloading. This has the added benefit of being explicit about the supported response types for each libosrm API method.
mjjbell
force-pushed
the
mbell/libosrm_api
branch
from
06da13d to
34cc00d
Compare
5 tasks
Member
Author
|
Replacing with #5861 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Removes the breaking libosrm API change by replacing the use of variant response type with method overloading.
This adds a bit of boilerplate to convert to/from the variant response used in plugin code. I avoided templating as I think this would have implications on the use of the pimpl pattern. Perhaps someone can correct me on this.
This also has the added benefit of being explicit about the supported response types for each libosrm API method.
Tasklist
Requirements / Relations
Closes #5741
Closes #5548