Removed un-needed calls to std::move#5561
Removed un-needed calls to std::move#5561gardster merged 2 commits intoProject-OSRM:masterfrom peoplestom:pessimistic_move
Conversation
|
First github PR in a while, let me know if I've missed something in the process. |
gardster
left a comment
gardster
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Please add GCC9.10 build to the CI rules https://github.com/Project-OSRM/osrm-backend/blob/master/.travis.yml
|
I believe I've now added gcc9 to Travis with my last push |
|
Thank you! It seems that CI found additional errors. Could you fix them? |
|
I missed that, I was working off the 5.22.0 tag. I have fixed the additional issues, it compiles and appears to work. |
These calls were throwing a pessimistic move error and stopping compilation.
|
I'll take a look on that flatbuffers issue next week. Hope it is not urgent :) |
|
Added #5566 on top of master that fixes flatbuffers caused compilation warnings |
|
@peoplestom Thank you for the fixes. |
|
I have clang-format 8.0.1, but the changes it kicked up were right were my edits were, so fingers crossed this is ready to merge! |
Compiling under gcc9.1 we get copy issues. It appears we shouldn't pass builder classes by value, only ref.
|
Thank you for your contribution! Now OSRM will be gcc9 compatible 🎉 |
|
Awesome! glad I could contribute |
- Changes from 5.22.0
- Build:
- FIXED: pessimistic calls to std::move [Project-OSRM#5560](Project-OSRM#5561)
- Features:
- ADDED: new API parameter - `snapping=any|default` to allow snapping to previously unsnappable edges [Project-OSRM#5361](Project-OSRM#5361)
- ADDED: keepalive support to the osrm-routed HTTP server [Project-OSRM#5518](Project-OSRM#5518)
- ADDED: flatbuffers output format support [Project-OSRM#5513](Project-OSRM#5513)
- ADDED: Global 'skip_waypoints' option [Project-OSRM#5556](Project-OSRM#5556)
- FIXED: Install the libosrm_guidance library correctly [Project-OSRM#5604](Project-OSRM#5604)
- FIXED: Http Handler can now deal witch optional whitespace between header-key and -value [Project-OSRM#5606](Project-OSRM#5606)
- Routing:
- CHANGED: allow routing past `barrier=arch` [Project-OSRM#5352](Project-OSRM#5352)
- CHANGED: default car weight was reduced to 2000 kg. [Project-OSRM#5371](Project-OSRM#5371)
- CHANGED: default car height was reduced to 2 meters. [Project-OSRM#5389](Project-OSRM#5389)
- FIXED: treat `bicycle=use_sidepath` as no access on the tagged way. [Project-OSRM#5622](Project-OSRM#5622)
- FIXED: fix table result when source and destination on same one-way segment. [Project-OSRM#5828](Project-OSRM#5828)
- FIXED: fix occasional segfault when swapping data with osrm-datastore and using `exclude=` [Project-OSRM#5844](Project-OSRM#5844)
- FIXED: fix crash in MLD alternative search if source or target are invalid [Project-OSRM#5851](Project-OSRM#5851)
- Misc:
- CHANGED: Reduce memory usage for raster source handling. [Project-OSRM#5572](Project-OSRM#5572)
- CHANGED: Add cmake option `ENABLE_DEBUG_LOGGING` to control whether output debug logging. [Project-OSRM#3427](Project-OSRM#3427)
- CHANGED: updated extent of Hong Kong as left hand drive country. [Project-OSRM#5535](Project-OSRM#5535)
- FIXED: corrected error message when failing to snap input coordinates [Project-OSRM#5846](Project-OSRM#5846)
- Infrastructure
- REMOVED: STXXL support removed as STXXL became abandonware. [Project-OSRM#5760](Project-OSRM#5760)
3 participants
These calls were throwing a pessimistic move error and stopping compilation on GCC 9.1.0
Issue
5560 pessimistic std::move calls
Tasklist
Requirements / Relations
N/A