Increase allowed shared memory regions to 512 from ~120.#5185
Merged
Conversation
Member
|
chaupow
requested changes
Sep 5, 2018
Member
chaupow
left a comment
chaupow
left a comment
There was a problem hiding this comment.
looks good. super minor remarks
package.json
Outdated
| { | ||
| "name": "osrm", | ||
| "version": "5.18.0-latest.1", | ||
| "version": "5.18.0-moarshm.3", |
Member
There was a problem hiding this comment.
for merging to master, we should undo this again, I guess :)
danpat
changed the title
danpat
force-pushed
the
danpat_more_shm_regions
branch
from
15a41ed to
2ff24f6
Compare
chaupow
approved these changes
Sep 5, 2018
datendelphin
added a commit
to fossgis-routing-server/osrm-backend
that referenced
this pull request
Nov 19, 2020
- Changes from 5.18.0:
- Optimizations:
- CHANGED: Use Grisu2 for serializing floating point numbers. [Project-OSRM#5188](Project-OSRM#5188)
- ADDED: Node bindings can return pre-rendered JSON buffer. [Project-OSRM#5189](Project-OSRM#5189)
- Profiles:
- CHANGED: Bicycle profile now blacklists barriers instead of whitelisting them [Project-OSRM#5076
](Project-OSRM#5076)
- CHANGED: Foot profile now blacklists barriers instead of whitelisting them [Project-OSRM#5077
](Project-OSRM#5077)
- CHANGED: Support maxlength and maxweight in car profile [Project-OSRM#5101](Project-OSRM#5101]
- Bugfixes:
- FIXED: collapsing of ExitRoundabout instructions [Project-OSRM#5114](Project-OSRM#5114)
- Misc:
- CHANGED: Support up to 512 named shared memory regions [Project-OSRM#5185](Project-OSRM#5185)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Currently, if you try to create more than 128 named datasets, some
std::uint8_tvalues will overflow, and you'll end up overwriting other datasets with different names, and/or crashing.This change increases the limit to 512. Achieving this requires a few steps:
::ftok()only uses the lowest 8 bits from theidfield, so we need to use more than one lockfile name to differentiate unique keys.std::uint8_ttostd::uint16_tto hold the larger values.Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?