Skip to content

Support maxlength and maxweight in car profile #5101

Merged
TheMarex merged 3 commits intoProject-OSRM:masterfrom
Mapotempo:mt_parse_value_kilograms
Jul 11, 2018
Merged

Support maxlength and maxweight in car profile #5101
TheMarex merged 3 commits intoProject-OSRM:masterfrom
Mapotempo:mt_parse_value_kilograms

Conversation

@frodrigo
Copy link
Copy Markdown
Member

@frodrigo frodrigo commented Jun 6, 2018

Support in car profile:

  • maxlength
  • maxweight

like maxheight and maxwidth.

@frodrigo frodrigo force-pushed the mt_parse_value_kilograms branch from 4626ad4 to e38a465 Compare June 6, 2018 12:23
Copy link
Copy Markdown
Member

@TheMarex TheMarex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a question with regard to a refactor you included, otherwise looks good to me!

end
end

--- according to http://wiki.openstreetmap.org/wiki/Map_Features/Units#Explicit_specifications
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you say more about why you removed the patterns in favor of the hard coded version?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's about implementing a more fail safe version and only extract partial value from the tag.

@TheMarex TheMarex merged commit f928956 into Project-OSRM:master Jul 11, 2018
@frodrigo
Copy link
Copy Markdown
Member Author

Thank

datendelphin added a commit to fossgis-routing-server/osrm-backend that referenced this pull request Nov 19, 2020
  - Changes from 5.18.0:
    - Optimizations:
      - CHANGED: Use Grisu2 for serializing floating point numbers. [Project-OSRM#5188](Project-OSRM#5188)
      - ADDED: Node bindings can return pre-rendered JSON buffer. [Project-OSRM#5189](Project-OSRM#5189)
    - Profiles:
      - CHANGED: Bicycle profile now blacklists barriers instead of whitelisting them [Project-OSRM#5076
](Project-OSRM#5076)
      - CHANGED: Foot profile now blacklists barriers instead of whitelisting them [Project-OSRM#5077
](Project-OSRM#5077)
      - CHANGED: Support maxlength and maxweight in car profile [Project-OSRM#5101](Project-OSRM#5101]
    - Bugfixes:
      - FIXED: collapsing of ExitRoundabout instructions [Project-OSRM#5114](Project-OSRM#5114)
    - Misc:
      - CHANGED: Support up to 512 named shared memory regions [Project-OSRM#5185](Project-OSRM#5185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants