Renumber node IDs in .osrm.maneuver_overrides#4907
Merged
Conversation
TheMarex
approved these changes
Feb 22, 2018
Member
TheMarex
left a comment
TheMarex
left a comment
There was a problem hiding this comment.
Thanks for running this our. Looks like you sneaked a refactor and a second bug fix into this. 💯 Looks good to me. 👍
| extractor::serialization::write( | ||
| writer, storage_maneuver_overrides, maneuver_override_sequences); | ||
|
|
||
| files::writeManeuverOverrides( |
| io::FileReader maneuver_overrides_file(config.GetPath(".osrm.maneuver_overrides"), | ||
| io::FileReader::VerifyFingerprint); | ||
| const auto number_of_overrides = maneuver_overrides_file.ReadElementCount64(); | ||
| const auto number_of_overrides = |
Member
There was a problem hiding this comment.
This is another bug fix: Without skipping the bytes of the vector this would read garbage data.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4906
/cc @chaupow @TheMarex
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?