Skip to content

Stop signs for the turn function in lua profiles#4828

Closed
chaupow wants to merge 3 commits intomasterfrom
feature/stops_in_turns
Closed

Stop signs for the turn function in lua profiles#4828
chaupow wants to merge 3 commits intomasterfrom
feature/stops_in_turns

Conversation

@chaupow
Copy link
Copy Markdown
Member

@chaupow chaupow commented Jan 24, 2018

Issue

Implementing #2652

Tasklist

@chaupow chaupow self-assigned this Jan 24, 2018
@chaupow chaupow force-pushed the feature/stops_in_turns branch from c6b0d47 to 6eb238b Compare January 24, 2018 23:17
@chaupow chaupow modified the milestone: 5.16.0 Feb 5, 2018
@SiarheiFedartsou
Copy link
Copy Markdown
Member

@mjjbell what do you think about it? Should we finish it?

@mjjbell
Copy link
Copy Markdown
Member

mjjbell commented Sep 22, 2022

Yes I think it's worth doing.

I remember reading this when implementing the traffic signal directions in #6153
It seems similar in that you need to know in the direction of approach to the node, so if this PR it too out-of-date, we could try and reuse that to implement it.

@mjjbell
Copy link
Copy Markdown
Member

mjjbell commented Sep 22, 2022

These changes look very similar to what I did for traffic signals, but they didn't make it to master: d1b9dff

@SiarheiFedartsou
Copy link
Copy Markdown
Member

Yes I think it's worth doing.

We should probably decide what to do with #6354 then - I would expect quite a lot of merge conflicts if do this in current code base and then try to merge #6354

@mjjbell
Copy link
Copy Markdown
Member

mjjbell commented Sep 25, 2022

Ok, I'll take a look soon.

@DennisOSRM
Copy link
Copy Markdown
Collaborator

closing stale PR. Reopen if still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants