Experimental version of tile plugin using vtzero.#4686
Merged
oxidase merged 2 commits intoProject-OSRM:subtrees-protozero-vtzerofrom Apr 24, 2018
joto:experimental/vtzero
Merged
Experimental version of tile plugin using vtzero.#4686oxidase merged 2 commits intoProject-OSRM:subtrees-protozero-vtzerofrom joto:experimental/vtzero
oxidase merged 2 commits intoProject-OSRM:subtrees-protozero-vtzerofrom
joto:experimental/vtzero
Conversation
Contributor
|
Thanks for getting this going @joto. I agree that this should wait to merge for an official vtzero release. At the same time, would be great if @danpat could find a moment to kick the tires on this to provide any feedback now that might help guide any needed changes in vtzero before official release. |
Member
|
Thanks this looks great, 300 LOC less 🎉 Looking forward to the vtzero release. |
Contributor
6 tasks
oxidase
force-pushed
the
subtrees-protozero-vtzero
branch
5 times, most recently
from
8a23681 to
5c4353b
Compare
This uses the new vtzero library (https://github.com/mapbox/vtzero) instead of using protozero directly.
TheMarex
approved these changes
Apr 24, 2018
Member
TheMarex
left a comment
TheMarex
left a comment
There was a problem hiding this comment.
So much more readable! 💯 Did you try these vector tiles with out debug viewer in osrm-frontend?
Contributor
|
@TheMarex debug tiles look good |
6 tasks
datendelphin
added a commit
to fossgis-routing-server/osrm-backend
that referenced
this pull request
Jun 10, 2018
Release OSRM 5.18.0 Changes from 5.17.0: - Features: - ADDED: `table` plugin now optionally returns `distance` matrix as part of response [Project-OSRM#4990](Project-OSRM#4990) - ADDED: New optional parameter `annotations` for `table` that accepts `distance`, `duration`, or both `distance,duration` as values [Project-OSRM#4990](Project-OSRM#4990) - Infrastructure: - ADDED: Updated libosmium and added protozero and vtzero libraries [Project-OSRM#5037](Project-OSRM#5037) - CHANGED: Use vtzero library in tile plugin [Project-OSRM#4686](Project-OSRM#4686) - Profile: - ADDED: Bicycle profile now returns classes for ferry and tunnel routes. [Project-OSRM#5054](Project-OSRM#5054) - ADDED: Bicycle profile allows to exclude ferry routes (default to not enabled) [Project-OSRM#5054](Project-OSRM#5054)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the new vtzero library (https://github.com/mapbox/vtzero)
instead of using protozero directly. The code becomes much cleaner this way and the generated tiles are smaller. Note that I have rewritten the code but only did a little bit of ad-hoc testing. To run this you'll need the newest release of protozero and vtzero master installed.
Issue
#4685
Tasklist
Requirements / Relations
Might need vendored in vtzero. The protozero vendered in with libosmium will need to be updated. Don't merge until there is an official released version of vtzero.
/cc @springmeyer