Discards construction and proposed ways, resolves #4230#4258
Merged
daniel-j-h merged 1 commit intomasterfrom Jul 10, 2017
Merged
Discards construction and proposed ways, resolves #4230#4258daniel-j-h merged 1 commit intomasterfrom
daniel-j-h merged 1 commit intomasterfrom
Conversation
Contributor
|
only thing i can think of is construction=no... is that a thing? |
emiltin
reviewed
Jul 9, 2017
features/car/construction.feature
Outdated
| | primary | | | x | | ||
| | construction | | | | | ||
| | proposed | | | | | ||
| | primary | primary | | | |
Contributor
There was a problem hiding this comment.
construction=primary is unorthodox. usually it's construction=yes
Member
Yes, there are a couple tags like |
TheMarex
approved these changes
Jul 10, 2017
Member
Author
|
Added negative tags and taginfo items. Cherry-picked into 5.9 branch. |
daniel-j-h
added a commit
that referenced
this pull request
Jul 19, 2017
TheMarex
pushed a commit
that referenced
this pull request
Jul 19, 2017
TheMarex
pushed a commit
that referenced
this pull request
Jul 19, 2017
lliehu
added a commit
to lliehu/cbf-routing-profiles
that referenced
this pull request
Jun 24, 2023
Routing on proposed ways was blacklisted only for car profile. This adds the same blacklisting also for foot and bike profiles. It looks like this behavior was added in Project-OSRM/osrm-backend#4258 and then accidentally reverted when pull request with title "profiles api v2" at Project-OSRM/osrm-backend#4072 was merged. This commit restores the original change for bike and foot profiles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #4230: discards
highway=construction,highway=proposed,construction=,proposed=.http://wiki.openstreetmap.org/wiki/Key:construction
http://wiki.openstreetmap.org/wiki/Key:proposed
http://wiki.openstreetmap.org/wiki/Key:highway
I see no reason we ever want to route over these tags. Please correct me if I'm wrong or if there are any edge cases I haven't thought of. Better to be safe than sorry here.
cc @emiltin @1ec5