Adds documentations on 'approaches' parameter.#4104
Merged
TheMarex merged 1 commit intoProject-OSRM:masterfrom May 31, 2017
Merged
Adds documentations on 'approaches' parameter.#4104TheMarex merged 1 commit intoProject-OSRM:masterfrom
TheMarex merged 1 commit intoProject-OSRM:masterfrom
Conversation
5 tasks
daniel-j-h
reviewed
May 30, 2017
Member
daniel-j-h
left a comment
daniel-j-h
left a comment
There was a problem hiding this comment.
Do we want to add a note or warning about the profile's left/right-hand-side driving? Technically it's a limitation on our side but the behavior will not be correct planet wide e.g. on the demo server if we use the default car profile.
CHANGELOG.md
Outdated
| - new parameter `approaches` for `route`, `table`, 'trip' and `nearest` requests. This parameter keep waypoints on the curb side | ||
| (depending 'left_hand_driving' parameter into lua script). 'approaches' accepts both 'curb' and 'unrestricted' values. | ||
| - NodeJs Bindings | ||
| - new parameter `approaches` for `route`, `table`, 'trip' and `nearest` requests. |
Member
There was a problem hiding this comment.
Could you use ` backticks for all highlighting here and above
Adds changelog Adds doc/http.md doc Adds doc/nodejs/api.md doc Signed-off-by: FILLAU Jean-Maxime <[email protected]>
Contributor
Author
|
I added a note to explain that. |
Member
|
Perfect thank you! (Travis test failing is unrelated, see #4110) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds documentations on 'approaches' parameter.
Issue
#2201
PR
#4039